[PATCH] D107381: [runtimeunroll] Support multiple exits to latch exit w/epilogue loop

Thu Aug 19 11:25:44 PDT 2021

bjope added a comment.

In D107381#2955288 <https://reviews.llvm.org/D107381#2955288>, @reames wrote:

> In D107381#2954577 <https://reviews.llvm.org/D107381#2954577>, @bjope wrote:
>
>> I'm seeing the same fault as @alanphipps when having build with LLVM_ENABLE_EXPENSIVE_CHECKS=ON and running the test/Transforms/LoopUnroll/runtime-loop-multiple-exits.ll test case.
>>
>> Should we revert this patch until this has been investigated further?
>
> Should be fixed in 447256f <https://reviews.llvm.org/rG447256f22b4dc125877aed11aac875c03d0228eb>.  If not, please revert both changes and I'll take another look.
>
> I do want to briefly address the revert question though.  I would not revert based on the first report.  There's no reproducer, and (I'm guessing) they're force enabling an internal flag.  That would definitely be an unsupported configuration.  Your second report is a supported configuration failing with an intree reproducer.  Reverting to green in that case would have been completely reasonable.

Thanks @reames, that sounds reasonable to me. There was no rush to revert from my point of view here (specially considering the quick fix, so it was more of a suggestion in case it would take days to fix the problem).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107381/new/

https://reviews.llvm.org/D107381