[PATCH] D108388: [Support] Move `MD5` members in `InternalState`.

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith added inline comments.


================
Comment at: llvm/include/llvm/Support/MD5.h:89-103
+  // Any 32-bit or wider unsigned integer data type will do.
+  typedef uint32_t MD5_u32plus;
+
+  // Internal State
+  struct {
+    MD5_u32plus a = 0x67452301;
+    MD5_u32plus b = 0xefcdab89;
----------------
arames wrote:
> arames wrote:
> > dexonsmith wrote:
> > > I suggest leaving the location in the file these in the file above. That'll remove the diff entirely on the `typedef`, and make much of the diff for the members whitespace-only. Unless there's a specific reason you were moving it?
> > This was to follow `SHA1` and `SHA256`, that also have it at the end. I don't care much. Let's minimize the diff.
> Actually. The next patch will need to add a `MD5Result` member, which needs to be declared after.
> So let's move the members as part of this NFC patch.
Sure, SGTM.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108388/new/

https://reviews.llvm.org/D108388