[PATCH] D108377: [asan] Implemented custom calling convention similar used by HWASan for X86.

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: llvm/include/llvm/Transforms/Instrumentation/AddressSanitizer.h:151
+// Get AddressSanitizer parameters.
+void getAddressSanitizerParams(Module &M, uint64_t *ShadowBase,
+                               int *MappingScale, bool *OrShadowOffset);
----------------
Could  please please replace Module with targetTriple and pointerSizeInBits.
We don't need entire module for that even if current callers have it.



================
Comment at: llvm/include/llvm/Transforms/Instrumentation/AddressSanitizerCommon.h:90
 
+void getASanShadowMapping(int *Scale, uint64_t *Offset, bool *OrShadowOffset);
+
----------------
I don't see implementation of this one.

And I expected getAddressSanitizerParams here, not in AddressSanitizer.h. Is there a reson to declare it there?



================
Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:566
 
+void getAddressSanitizerParams(Module &M, uint64_t *ShadowBase,
+                               int *MappingScale, bool *OrShadowOffset) {
----------------
It would be nice to introduce this function as a separate NFC patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108377/new/

https://reviews.llvm.org/D108377