[PATCH] D108322: AMDGPU: Add options to override SGPR and VGPR blocks

[Konstantin Zhuravlyov via Phabricator via llvm-commits]

kzhuravl added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:4815
+  if (auto OverrideVGPRBlocks = AMDGPU::overrideVGPRBlocks())
+    VGPRBlocks = *OverrideVGPRBlocks;
+  if (auto OverrideSGPRBlocks = AMDGPU::overrideSGPRBlocks())
----------------
t-tye wrote:
> Should this set to max of calculated and overridden value? We do not want to override to force fewer registers than the code actually uses. Same comment for SGPR.
Instead of setting max, can we return error saying "cannot override because isa is using more registers"?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108322/new/

https://reviews.llvm.org/D108322