[PATCH] D106888: [RISC-V] Implement jump tables for CFI-icall

Wende Tan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 19 08:15:34 PDT 2021


twd2 added a comment.

In D106888#2954571 <https://reviews.llvm.org/D106888#2954571>, @luismarques wrote:

> In D106888#2954425 <https://reviews.llvm.org/D106888#2954425>, @asb wrote:
>
>> Is it possible to write a test case for this?
>
> Good question. I had checked that the AArch64 implementation had included a test, but I think that was only for new target-specific stuff, which doesn't apply here. So I was assuming the answer was no, but it would be good to get confirmation. I was also confused by the comment about "the build failure", since this applied cleanly and built OK for me when I looked at it.

Hi, you can check here: https://buildkite.com/llvm-project/premerge-checks/builds/49755#814fd222-2e5a-4400-824d-d1a1f1293c01
The clang-tidy failed due to the invalid case style for variable 'kRISCVJumpTableEntrySize'.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106888/new/

https://reviews.llvm.org/D106888



More information about the llvm-commits mailing list