[PATCH] D105351: [VP] Declaration and docs for vp.select intrinsic

[Fraser Cormack via Phabricator via llvm-commits]

frasercrmck added a comment.

Just nits and questions are this stage, really.



================
Comment at: llvm/docs/LangRef.rst:17753
+
+The first operand is a vector of ``i1`` and indicates the mask.  The second
+operand is the value that is selected when the condition is true.  The third
----------------
Nit: the `select` instruction is defined as having a "condition" whereas this is a "mask". There's a bit of mixing of "mask" and "condition" in the follow paragraphs too. Should we try to stick to "condition"?


================
Comment at: llvm/include/llvm/IR/Intrinsics.td:1510
 }
+// Shuffles.
+def int_vp_select : DefaultAttrsIntrinsic<[ llvm_anyvector_ty ],
----------------
Nit: is this really a shuffle? I guess in a way it is, but it feels like "shuffles" and "selects" are already two distinct terms in the non-VP world.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105351/new/

https://reviews.llvm.org/D105351