[PATCH] D108375: [GlobalISel] Support ConstantAsMetadata in IRTranslator

[Aleksandr Bezzubikov via Phabricator via llvm-commits]

zuban32 created this revision.
Herald added subscribers: hiraditya, rovka.
zuban32 requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

When using instructions which have a MetadataAsValue argument
(e.g. some target-specific intrinsics)
MD canonicalization strips internal MDNodes with a
single ConstantAsMetadata child. That prevented IRTranslator
from the proper translation of such a calls.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D108375

Files:
  llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp


Index: llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp
===================================================================
--- llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp
+++ llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp
@@ -2368,10 +2368,15 @@
       } else {
         MIB.addFPImm(cast<ConstantFP>(Arg.value()));
       }
-    } else if (auto MD = dyn_cast<MetadataAsValue>(Arg.value())) {
-      auto *MDN = dyn_cast<MDNode>(MD->getMetadata());
-      if (!MDN) // This was probably an MDString.
-        return false;
+    } else if (auto MDVal = dyn_cast<MetadataAsValue>(Arg.value())) {
+      auto *MD = MDVal->getMetadata();
+      auto *MDN = dyn_cast<MDNode>(MD);
+      if (!MDN) {
+        if (auto *ConstMD = dyn_cast<ConstantAsMetadata>(MD))
+          MDN = MDNode::get(MF->getFunction().getContext(), ConstMD);
+        else // This was probably an MDString.
+          return false;
+      }
       MIB.addMetadata(MDN);
     } else {
       ArrayRef<Register> VRegs = getOrCreateVRegs(*Arg.value());


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D108375.367494.patch
Type: text/x-patch
Size: 1015 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210819/e5bb14ee/attachment.bin>