[PATCH] D108363: [AMDGPU] Propagate !noalias and !alias.scope metadata in AMDGPULowerKernelArguments for noalias arguments.

[Abinav Puthan Purayil via Phabricator via llvm-commits]

abinavpp added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/lower-kernargs.ll:1280
 ;
   store volatile i8 addrspace(1)* %ptr0, i8 addrspace(1)* addrspace(1)* undef
   store volatile i8 addrspace(1)* %ptr1, i8 addrspace(1)* addrspace(1)* undef
----------------
jeroen.dobbelaere wrote:
> What is the purpose of this test ? The kernel input pointers are 'stored to `undef`', as such those stores see the available noalias scopes, but do not take part in it. Shouldn't the test store something to the pointers instead ?
> 
I'm not sure about the stores to undefs in AMDGPU/lower-kernargs.ll. This test was added in the initial commit for AMDGPULowerKernelArguments. I assume we're just checking the generated IR for the stores and not worrying about the destination. @arsenm is that right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108363/new/

https://reviews.llvm.org/D108363