[PATCH] D108362: [NewPM] Use parameterized syntax for a couple of more passes

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope created this revision.
bjope added a reviewer: aeubanks.
Herald added subscribers: asbirlea, george.burgess.iv, hiraditya.
bjope requested review of this revision.
Herald added a project: LLVM.

A couple of passes that are parameterized in new-PM used different
pass names (in cmd line interface) while using the same pass class
name. This patch updates the PassRegistry to model pass parameters
more properly using PASS_WITH_PARAMS.

Reason for the change is to ensure that we have a 1-1 mapping
between class name and pass name (when disregarding the params).
With a 1-1 mapping it is more obvious which pass name to use in
options such as -debug-only, -print-after etc.

The opt -passes syntax is changed for the following passes:

  early-cse-memssa => early-cse<memssa>
  post-inline-ee-instrument => ee-instrument<post-inline>
  loop-extract-single => loop-extract<single>
  lower-matrix-intrinsics-minimal => lower-matrix-intrinsics<minimal>

This patch is not updating pass names in docs/Passes.rst. Not quite
sure what the status is for that document (e.g. when it comes to
listing pass paramters). It is only loop-extract-single that is
mentioned in Passes.rst today, out of the passes mentioned above.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D108362

Files:
  llvm/lib/Passes/PassBuilder.cpp
  llvm/lib/Passes/PassRegistry.def
  llvm/test/Analysis/MemorySSA/invalidate.ll
  llvm/test/Transforms/EarlyCSE/AArch64/intrinsics.ll
  llvm/test/Transforms/EarlyCSE/memoryssa.ll
  llvm/test/Transforms/EntryExitInstrumenter/debug-info.ll
  llvm/test/Transforms/EntryExitInstrumenter/mcount.ll
  llvm/test/Transforms/LowerMatrixIntrinsics/multiply-minimal.ll
  llvm/tools/opt/NewPMDriver.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D108362.367446.patch
Type: text/x-patch
Size: 11928 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210819/b0f458ae/attachment.bin>