[PATCH] D107034: [CSPGO] Set EnableValueProfiling flag for CSPGO to avoid IRPGO value loss in LTO

[Yolanda via Phabricator via llvm-commits]

YolandaCY added a comment.

In D107034#2953729 <https://reviews.llvm.org/D107034#2953729>, @MaskRay wrote:

> I edited my comment a bit so your email notification may not catch it.
> This looks to me a PE/COFF specific issue. I wonder whether we can drop link.exe support for PGO / CSPGO.
> link.exe has the limitation "non-leader members of a comdat must be private".
> I recall that PE/COFF can entirely use the ELF scheme if we can lift the limitation.
> (https://lists.llvm.org/pipermail/llvm-dev/2021-May/150758.html)

I think I used lld-link.exe, not MSVC's link.exe. As mentioned in the link,

> lld-link doesn't have this limitation.

I hope my last reply will help resolve some confusion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107034/new/

https://reviews.llvm.org/D107034