[PATCH] D108357: [AMDGPU][GlobalISel] Legalize memcpy family of intrinsics

[Mirko Brkusanin via Phabricator via llvm-commits]

mbrkusanin added a comment.

This is the same solution from CombinerHelper with minor changes. However it makes more sense to use it in legalizer since they are required for correctnes.

AArch64 currently uses those combines in PreLegalizerCombiner. We have 3 options:

1. Custom AMDGPU lowering (current solution, copies code)
2. Use same combines in AMDGPUPreLegalizerCombiner (correcntess issue)
3. Move combines into LegalizerHelper (AArch64 will be using them in legalzer, I don't see a nice way of using a LegalizerHelper method in combiner).

Also which tests should I keep, .ll or .mir?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108357/new/

https://reviews.llvm.org/D108357