[PATCH] D108323: [asan] Added -inline-small-callbacks LLVM flag, which would force inline code for 8 and 16 byte data types when otherwise a callback would have been used.

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 19 02:18:58 PDT 2021


vitalybuka added inline comments.


================
Comment at: clang/test/CodeGen/asan-use-callbacks.cpp:15
 
-int deref(int *p) {
+long deref(long *p) {
   return *p;
----------------
kcc wrote:
> As we introduce a difference in behavior for small and large accesses, 
> I would extend this test to have 1, 2, 4, and 16-byte accesses. 
changes in llvm/lib should be tested in corresponding llvm/test, not clang/test


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108323/new/

https://reviews.llvm.org/D108323



More information about the llvm-commits mailing list