[PATCH] D106947: [DSE][NFC] Rename Later->Killing, Earlier->Killed
Alina Sbirlea via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 18 16:34:28 PDT 2021
asbirlea added a comment.
Thank you for doing this cleanup!
I agree the new names are more descriptive, but my feedback is that the code becomes very hard to read. I for one have a hard time following where in the code it says `Killing` and where `Killed` after the refactoring.
May I suggest using `Killing` and `Dead` (or variations of `PotentiallyDead`/`MaybeDead` etc)? Happy to hear other suggestions of names that have different "root" not just different declension.
Disclaimer: I'm not a native speaker either, just giving some thoughts :-).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106947/new/
https://reviews.llvm.org/D106947
More information about the llvm-commits
mailing list