[PATCH] D108271: [NFC][DebugInfo] getDwarfCompileUnitID
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 18 16:08:56 PDT 2021
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
In D108271#2953354 <https://reviews.llvm.org/D108271#2953354>, @kyulee wrote:
> In D108271#2953310 <https://reviews.llvm.org/D108271#2953310>, @dblaikie wrote:
>
>> Perhaps the name of the function should have something to do with line tables, since this is only for use when generating line tables (& in non-line table situations the code should use the CU.getUniqueID directly, I think?)?
>
> What about `getDwarfCompileUnitIDForLineTable`?
Sure, sounds good!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108271/new/
https://reviews.llvm.org/D108271
More information about the llvm-commits
mailing list