[PATCH] D108120: [lld] Add CMake options to disable individual linkers

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 18 15:09:09 PDT 2021


arichardson added a comment.

In D108120#2952966 <https://reviews.llvm.org/D108120#2952966>, @thakis wrote:

> If this doesn't help you much upstream, and since it's not a big size change, is it really worth to add the complexity here upstream?
>
> (Don't worry about the gn build though, that's easy to update if this lands.)

While it doesn't help very much for FreeBSD (one of the downstream forks I contribute to) since FreeBSD doesn't use the CMake build system, it does help for the CHERI downstream (the downstream fork I work on for my job).
I think this doesn't add very much complexity: just a few ifdefs in a file that rarely changes and a few if() statements in CMake.

To me a 3.8MB size reduction seems worth this complexity but if you disagree I can commit this downstream instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108120/new/

https://reviews.llvm.org/D108120



More information about the llvm-commits mailing list