[PATCH] D108324: [RISCV] Reduce duplicate code for calling SimplifyDemandedBits.

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 18 12:52:16 PDT 2021


jrtc27 added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:5970
+// Caller should return SDValue(N, 0) if this returns true.
+static bool SimplifyDemandedLowBitsHelper(SDNode *N, unsigned OpNo,
+                                          unsigned LowBits,
----------------
Do you intend to call this from other functions too? If not, you could make it a lambda and avoid having to pass N, DCI and TLI.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108324/new/

https://reviews.llvm.org/D108324



More information about the llvm-commits mailing list