[PATCH] D108319: [doc][GlobalISel]Improving generic opcodes for memory operations

PoojaYadav via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 18 12:30:26 PDT 2021


pooja2299 added inline comments.


================
Comment at: llvm/docs/GlobalISel/GenericOpcode.rst:684-685
+$addr is set to $base + $offset.
 If $am is 0 (post-indexed), then the value is loaded from $base; if $am is 1 (pre-indexed)
-then the value is loaded from $newaddr.
+then the value is loaded from $addr. 
 
----------------
I am not aware that with what reference previous author has written this example, so needed guidance before changing it .


================
Comment at: llvm/docs/GlobalISel/GenericOpcode.rst:709
 
 Combines a store with a GEP. See description of G_INDEXED_LOAD for indexing behaviour.
 
----------------
Should I add the description of below example instead of this line?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108319/new/

https://reviews.llvm.org/D108319



More information about the llvm-commits mailing list