[PATCH] D108037: [X86] Implement llvm.isnan(x86_fp80) as unordered comparison

Siva Chandra via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 18 11:33:42 PDT 2021


sivachandra accepted this revision.
sivachandra added a comment.
This revision is now accepted and ready to land.

I think the current version of the patch restores the previous behavior so should be good to go. I am accepting but I am also not an expert in the area touched here. So, I will let the author @sepavloff decide how they want to proceed.

Also, I would like to understand why we cannot use `fxam` for all cases. For, exceptions can be enabled and disabled from software and should not affect the behavior of `isnan`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108037/new/

https://reviews.llvm.org/D108037



More information about the llvm-commits mailing list