[PATCH] D107935: [InstCombine] Avoid folding GEPs across loop boundaries
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 18 11:03:02 PDT 2021
lebedev.ri accepted this revision.
lebedev.ri added a comment.
This revision is now accepted and ready to land.
Hm, i thought i commented here, but alas not. LGTM.
I suspect while we want to merge this, it's only half of the story - what if LICM didn't run yet?
We need some kind of an undo transform. (and no, `SeparateConstOffsetFromGEP` doesn't help, i tried)
================
Comment at: llvm/lib/Transforms/InstCombine/InstructionCombining.cpp:2135
+ // when there wasn't an equivalent instruction there before.
+ bool DifferentLoops = false;
+ if (LI)
----------------
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107935/new/
https://reviews.llvm.org/D107935
More information about the llvm-commits
mailing list