[PATCH] D108259: [AArch64][GlobalISel] Legalize scalar G_FMINNUM + G_FMAXNUM

[Jessica Paquette via Phabricator via llvm-commits]

paquette added inline comments.


================
Comment at: llvm/lib/Target/AArch64/GISel/AArch64LegalizerInfo.cpp:734-735
+      .libcallFor({s128})
+      .widenScalarToNextPow2(0)
+      .clampScalar(0, MinFPScalar, s128);
+
----------------
aemerson wrote:
> Is this actually needed? We don't support any non-pow-2 FP types right?
Yeah actually I think all we need to do is widen from s16 if full 16-bit FP support isn't available.

https://godbolt.org/z/3n4WoMaWd




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108259/new/

https://reviews.llvm.org/D108259