[PATCH] D108307: [DAG] CombineConsecutiveLoads - replace getABITypeAlign with allowsMemoryAccess (PR45116)

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon created this revision.
RKSimon added reviewers: efriedma, lebedev.ri, spatel, craig.topper, pengfei.
Herald added subscribers: ecnelises, hiraditya.
RKSimon requested review of this revision.
Herald added a project: LLVM.

One of the cases identified in PR45116 - we don't need to limit load combines (in this case for ISD::BUILD_PAIR) to ABI alignment, we can use allowsMemoryAccess - which tests using getABITypeAlign, but also checks if a target permits misaligned memory loads by checking allowsMisalignedMemoryAccesses as a fallback.

This helps in particular for 32-bit X86 cases loading 64-bit size data, reducing codegen diffs vs x86_64.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D108307

Files:
  llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
  llvm/test/CodeGen/X86/avx512-mask-op.ll
  llvm/test/CodeGen/X86/avx512bw-intrinsics-upgrade.ll
  llvm/test/CodeGen/X86/avx512vbmi2-intrinsics-upgrade.ll
  llvm/test/CodeGen/X86/avx512vbmi2-intrinsics.ll
  llvm/test/CodeGen/X86/pr35982.ll
  llvm/test/CodeGen/X86/vector-shuffle-combining-avx512bw.ll
  llvm/test/CodeGen/X86/vector-shuffle-combining-avx512vbmi.ll
  llvm/test/CodeGen/X86/xmulo.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D108307.367242.patch
Type: text/x-patch
Size: 29904 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210818/9940662c/attachment.bin>