[PATCH] D107904: [LegalizeTypes][VP] Add widening support for binary VP ops
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 18 10:07:19 PDT 2021
craig.topper added a comment.
RISCV test changes LGTM
================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:3250
+ // may not actually need widening, leading it be split along with the VP
+ // operation. This could lead to an infinite split/widen loop. We only handle
+ // the case where the mask needs widening to an identically-sized type as the
----------------
This deserves a FIXME. AVX512 may want to use VP for predication and this would need to be fixed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107904/new/
https://reviews.llvm.org/D107904
More information about the llvm-commits
mailing list