[PATCH] D108281: [GVN] Improve alias analysis for parallel accesses

[Alban Bridonneau via Phabricator via llvm-commits]

alban.bridonneau added a comment.

Could I have some more information with regards to the proposed changes?

- With regards to having the correct loop, i am guessing what we want is to use the loop directly related to the basic block of the query instruction. I am envisioning something like

  BasicBlock *BB1= QueryInst->getParent();
  Loop *L = Loops.getLoopFor(BB1);

In which case, we can remove the BB argument to the function created in this patch, and we can also ensure that both the QueryInst and the DepInst are from the same Basic Block, and and the same loop. Does that match what you had in mind?

- With regards to using this metadata for better alias analysis, does that mean the particular case in this patch is alright with you?




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108281/new/

https://reviews.llvm.org/D108281