[PATCH] D108217: [Flang] Port test_folding.sh to Python

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 18 09:54:59 PDT 2021


Meinersbur added inline comments.


================
Comment at: flang/test/Evaluate/test_folding.py:66
+srcdir = set_source(sys.argv[1]).resolve()
+with open(srcdir, 'r') as f:
+    src = f.readlines()
----------------
cf folding05.f90: 
Consider specifying `encoding="utf-8"`. [[ https://docs.python.org/3.9/library/functions.html#open | Docs  ]] mention that the default-encoding is platform-dependent and it seems to be UTF-8 on Linux but cp1252 (Maybe dependent on localization) on Windows.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108217/new/

https://reviews.llvm.org/D108217



More information about the llvm-commits mailing list