[PATCH] D107692: [DAGCombine] Prevent the transform of combine for multi-use operand

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:5152-5156
+  // FIXME: Add one-use check as there is CombineTo call on N0, which will
+  // affect all users of N0. Need rewrite the transform as extra instruction
+  // bloat after this quick fix.
   if (N0.getOpcode() == ISD::ADD && N1.getOpcode() == ISD::SRL &&
+      VT.getSizeInBits() <= 64 && N0->hasOneUse()) {
----------------
How can this FIXME ever be addressed, given that there already is an one-use check?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107692/new/

https://reviews.llvm.org/D107692