[PATCH] D108253: [WIP][X86] Introduce 'blend with broadcast' shuffle lowering strategy (PR50971)

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 18 08:30:22 PDT 2021


lebedev.ri updated this revision to Diff 367220.
lebedev.ri added a comment.

Fixed the obvious miscompile w/ input picking

Ok, this is mostly it.
Interestingly, the originally-reported pattern appears to be the only problematic one
out of an exhaustive test coverage in `copy-low-subvec-elt-to-high-subvec-elt.ll`.

Now, am i wildly off-base here, should i be simply using/extending some existing lowering?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108253/new/

https://reviews.llvm.org/D108253

Files:
  llvm/lib/Target/X86/X86ISelLowering.cpp
  llvm/test/CodeGen/X86/copy-low-subvec-elt-to-high-subvec-elt.ll
  llvm/test/CodeGen/X86/horizontal-sum.ll
  llvm/test/CodeGen/X86/subvector-broadcast.ll
  llvm/test/CodeGen/X86/vector-shuffle-combining-avx.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D108253.367220.patch
Type: text/x-patch
Size: 16328 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210818/c92f4400/attachment.bin>


More information about the llvm-commits mailing list