[PATCH] D107193: [Zorg] Don't delete test-suite source directory every time.
Michael Kruse via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 18 08:23:56 PDT 2021
Meinersbur added a comment.
In D107193#2952208 <https://reviews.llvm.org/D107193#2952208>, @JonChesterfield wrote:
> The existing logic to delete the source directory might be there because the test programs write stuff into the source directory, so a clean build needs to blow that away.
That's not a/the reason. Currently, zorg/LLVM's buildbot setup never deletes or cleans the the llvm-project.git checkout (unless done manually) and this has not been a problem so far. Buildbot runs `git reset --hard` has part of its normal checkout step.
This patch tries to apply the same logic to the llvm-test-suite.git checkout as it currently does to the llvm-project.git checkout.
> Can we do a halfway-change here? In particular, if the downloaded repos are managed by git or similar, we could 'clean' the directories by `git clean -fd` instead of rm, which preserves the clean build behaviour and avoids redownloading the data.
`git clean -xfd` as part of the checkout process might be a good idea in case any files (particularly `__pycache__`). However, this is not what this patch is trying to fix.
Repository:
rZORG LLVM Github Zorg
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107193/new/
https://reviews.llvm.org/D107193
More information about the llvm-commits
mailing list