[PATCH] D108290: Update {Small}BitVector size_type definition

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 18 08:18:29 PDT 2021


rengolin added a comment.

The last clang-tidy warning (`capacity_in_bytes`) is pertinent but not for this patch.

A code grep on the whole of LLVM shows that it's never used internally, but both `DenseMap` and `SmallVector` have the same interface (although, neither use it externally either).

Clang only seems to use `llvm::capacity_in_bytes` (defined in `Support/Capacity.h`), so the public API of these containers can change independently.

In theory, we could change all of them to fit the standard, but given that this isn't the review that looks at that, and we were accidentally touching that code, I'll leave it for another commit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108290/new/

https://reviews.llvm.org/D108290



More information about the llvm-commits mailing list