[PATCH] D106960: [OffloadArch] Library to query properties of current offload archicture

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added inline comments.


================
Comment at: llvm/lib/OffloadArch/OffloadArch.cpp:280
+  return results;
+}
----------------
the _aot_ names are not great.


================
Comment at: llvm/lib/OffloadArch/amdgpu/hsa-subset.h:40
+// DEALINGS WITH THE SOFTWARE.
+//
+////////////////////////////////////////////////////////////////////////////////
----------------
licence is wrong.


================
Comment at: llvm/lib/OffloadArch/offload-arch/offload-arch.cpp:93
+\n\
+");
+  exit(1);
----------------
This is not AMD.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106960/new/

https://reviews.llvm.org/D106960