[PATCH] D108281: [GVN] Improve alias analysis for parallel accesses

[Bardia Mahjour via Phabricator via llvm-commits]

bmahjour added a comment.

Based on the current definition of `llvm.loop.parallel_accesses` it's not clear if it can be used to draw conclusions about aliasing. That MD only really provides guarantees about lack of loop-carried dependencies. The load/stores could still alias if they have loop-independent (ie intra-iteration) dependencies.



================
Comment at: llvm/include/llvm/Analysis/MemoryDependenceAnalysis.h:467
+  /// analysis and find a more appropriate dependent instruction.
+  bool isSameLoopAccessGroup(Instruction *QueryInst, Instruction *DepInst,
+                             BasicBlock *BB);
----------------
`belongToSameLoopParallelAccessGroup` might be a more appropriate name.
Is the BB parameter really needed? If so a comment should be added to describe what it is. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108281/new/

https://reviews.llvm.org/D108281