[compiler-rt] 7338be0 - [tsan] Disable Trace.MemoryAccessSize on Mac

Alexander Potapenko via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 18 06:09:49 PDT 2021


Author: Alexander Potapenko
Date: 2021-08-18T15:09:36+02:00
New Revision: 7338be0e6e8d09187f858d087df26914d201cb79

URL: https://github.com/llvm/llvm-project/commit/7338be0e6e8d09187f858d087df26914d201cb79
DIFF: https://github.com/llvm/llvm-project/commit/7338be0e6e8d09187f858d087df26914d201cb79.diff

LOG: [tsan] Disable Trace.MemoryAccessSize on Mac

According to comments at https://reviews.llvm.org/D107911,
Trace.MemoryAccessSize fails on Mac buildbots.
Because this test is newly introduced, and is the only user of the code
added in that patch, disable the test on Mac till the problem is
resolved.

Differential Revision: https://reviews.llvm.org/D108294

Added: 
    

Modified: 
    compiler-rt/lib/tsan/tests/unit/tsan_trace_test.cpp

Removed: 
    


################################################################################
diff  --git a/compiler-rt/lib/tsan/tests/unit/tsan_trace_test.cpp b/compiler-rt/lib/tsan/tests/unit/tsan_trace_test.cpp
index f9d9b645335b6..25bc5500e0f0b 100644
--- a/compiler-rt/lib/tsan/tests/unit/tsan_trace_test.cpp
+++ b/compiler-rt/lib/tsan/tests/unit/tsan_trace_test.cpp
@@ -76,7 +76,14 @@ TEST(Trace, RestoreAccess) {
   run_in_thread(Thread::Func);
 }
 
-TEST(Trace, MemoryAccessSize) {
+#if SANITIZER_MAC
+// Trace.MemoryAccessSize is currently failing on Mac.
+// See https://reviews.llvm.org/D107911 for more details.
+#  define MAYBE_MemoryAccessSize DISABLED_MemoryAccessSize
+#else
+#  define MAYBE_MemoryAccessSize MemoryAccessSize
+#endif
+TEST(Trace, MAYBE_MemoryAccessSize) {
   struct Thread {
     struct Params {
       uptr access_size, offset, size;


        


More information about the llvm-commits mailing list