[PATCH] D81999: libclc: Fix rounding during type conversion

Wed Aug 18 04:08:21 PDT 2021

daniels added a comment.

In D81999#2599293 <https://reviews.llvm.org/D81999#2599293>, @jvesely wrote:

> it took a while to test both versions. this patch fixes the following conversion tests:
>
>   	 *** 622) convert_floatn_rtp( uintn ) FAILED ** 
>   	 *** 627) convert_floatn_rtp( intn ) FAILED ** 
>   	 *** 639) convert_floatn_rtz( doublen ) FAILED ** 
>   	 *** 649) convert_floatn_rtz( longn ) FAILED ** 
>   	 *** 689) convert_doublen_rtz( doublen ) FAILED ** 
>
> The number of failed cases goes down from 42 to 37

Great, thanks ... is there any reason not to land this now?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D81999/new/

https://reviews.llvm.org/D81999