[PATCH] D106643: [llvm-readobj][XCOFF] Add support for `--needed-libs` option.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In D106643#2951573 <https://reviews.llvm.org/D106643#2951573>, @Esme wrote:

> In D106643#2951531 <https://reviews.llvm.org/D106643#2951531>, @jhenderson wrote:
>
>> I think you need testing for long names in your test case, to show the column width adjustments.
>
> I think the test case is enough? Because the default width is 13, and `libunwind.so.1`'s width is 14.

That's only the Member column. The Base column needs the same testing, as it is in fact the one that's more important. In fact, you could probably drop references to MemberWidth, thinking about it, since it has no impact on anything useful, as far as I understand it - having trailing spaces on the column is not useful. Thoughts?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106643/new/

https://reviews.llvm.org/D106643