[PATCH] D107904: [LegalizeTypes][VP] Add widening support for binary VP ops

[Fraser Cormack via Phabricator via llvm-commits]

frasercrmck added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:3428
+                     {InOp1, InOp2, Mask, N->getOperand(3)}, N->getFlags());
+}
+
----------------
RKSimon wrote:
> Do we gain much by keeping this separate instead of just adding VP handling to WidenVecRes_Binary ?
Nah perhaps not. I was indecisive but eventually chose to separate them so we didn't "pollute" the handling of "core" operations with the VP logic. I thought it might be an easier sell.

Since I've heard other people say they could be combined, I'll update this patch to unify the two.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107904/new/

https://reviews.llvm.org/D107904