[PATCH] D105720: [AsmParser] Add support to LOCAL directive.

Jian Cai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 17 16:19:51 PDT 2021


jcai19 added a comment.

In D105720#2950863 <https://reviews.llvm.org/D105720#2950863>, @MaskRay wrote:

> I still don't see a sufficient justification for making the change.

Would supporting this directive to match GNU spec be a sufficient justification? I've reduced the implementation to 50 lines of code, so hopefully this is a less significant change compared to my initial implementation. I also found many tests in GAS test suite for this directive, so this should also help if anyone is interested in running GAS test suite with IAS to assess the incompatibility between IAS and GAS.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105720/new/

https://reviews.llvm.org/D105720



More information about the llvm-commits mailing list