[PATCH] D106615: [Clang][LLVM] generate btf_tag annotations for DIComposite types

Tue Aug 17 15:58:15 PDT 2021

dblaikie added a comment.

In D106615#2949685 <https://reviews.llvm.org/D106615#2949685>, @yonghong-song wrote:

> @dblaikie ping. Could you help take a look at the patch?

Yeah, it's on my list.

================
Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:3478-3479

+  if (D->hasAttr<BTFTagAttr>())
+    RealDecl->replaceAnnotations(CollectBTFTagAnnotations(D));
+
----------------
Any reason this has to be done with a replace-style API, rather than constructed when the DI node is constructed in the first place?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106615/new/

https://reviews.llvm.org/D106615