[PATCH] D108238: [lit] Add option to output test result as resultdb json format.

Haowei Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 17 14:41:04 PDT 2021


haowei added a comment.

In D108238#2950560 <https://reviews.llvm.org/D108238#2950560>, @yln wrote:

> Hi Haowei,
>
> Can you change this to be a new type of report instead of changing an existing one?
> Look at `TimeTraceReport` for the recipe.  Maybe `--resultdb-output` and `ResultDbReport` are appropriate names for parameter/class name?
>
> This way the change would be purely additive and I then would be okay landing this as-is, i.e., without tests and documentation.  It would then be "your problem" if we (upstream) break this functionality.  This is only holds if my fellow reviewers think this okay as well, of course.

I forgot to include the unit tests in the previous change, sorry about that. I was hoping to reuse the code instead of re-inventing the wheels but if adding a new type of report is what you strongly suggest, I can work on implementing that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108238/new/

https://reviews.llvm.org/D108238



More information about the llvm-commits mailing list