[PATCH] D108237: Update bazel examples.
Geoffrey Martin-Noble via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 17 14:00:13 PDT 2021
GMNGeoffrey accepted this revision.
GMNGeoffrey added a comment.
This revision is now accepted and ready to land.
LGTM with a few fixes
================
Comment at: utils/bazel/examples/http_archive/WORKSPACE:30
-# FIXME: It shouldn't be necessary to use http_archive twice here. Caching
-# should mean that this isn't too expensive though.
-
-http_archive(
- name = "llvm-project-raw",
- build_file_content = "#empty",
+new_http_archive(
+ name = "llvm-archive",
----------------
I believe this has been deprecated since initial release (https://docs.bazel.build/versions/0.17.1/be/workspace.html#new_http_archive) and removed since 0.23.0 (https://docs.bazel.build/versions/0.23.0/be/workspace.html). You should just be able to use http_archive
================
Comment at: utils/bazel/examples/http_archive/WORKSPACE:38
-http_archive(
- name = "llvm-bazel",
- sha256 = LLVM_SHA256,
- strip_prefix = "llvm-project-{}/utils/bazel".format(LLVM_COMMIT),
- urls = ["https://github.com/llvm/llvm-project/archive/{commit}.tar.gz".format(commit = LLVM_COMMIT)],
-)
-
-load("@llvm-bazel//:configure.bzl", "llvm_configure", "llvm_disable_optional_support_deps")
+load("@llvm-archive//utils/bazel:configure.bzl", "llvm_configure")
----------------
This was broken before too, but we need to import `llvm_disable_optional_support_deps` as well
================
Comment at: utils/bazel/examples/submodule/WORKSPACE:27
-load("@llvm-bazel//:configure.bzl", "llvm_configure", "llvm_disable_optional_support_deps")
+load("@llvm-archive//utils/bazel:configure.bzl", "llvm_configure")
----------------
Same as above. We should be loading `llvm_disable_optional_support_deps` here
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108237/new/
https://reviews.llvm.org/D108237
More information about the llvm-commits
mailing list