[PATCH] D106947: [DSE][NFC] Rename Later->Killing, Earlier->Killed

Tue Aug 17 13:29:52 PDT 2021

fhahn added reviewers: nikic, asbirlea, dmgreen.
fhahn added a comment.

In D106947#2946036 <https://reviews.llvm.org/D106947#2946036>, @ebrevnov wrote:

> English is not my native language so I may be mistaken. Google translate gives "killed" for adverb with the meaning of not yet completed action. Maybe there is another form for that?
> Even though I like Killing/Killed pair more than Earlier/Later that's not the biggest deal. Biggest problem for me is inconsistency in naming. Sometimes It is hard to follow what is what. So I can go with Earlier/Later taken it is used consistently across source code.

Thanks for tackling the inconsistencies in the naming! I'm also not a native speaker so I am also not entirely sure about the subtleties. I've added a few other people who worked on DSE and may have additional thoughts/suggestions how to name the arguments as clearly as possible.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106947/new/

https://reviews.llvm.org/D106947