[PATCH] D100302: [VectorCombine] Run load/extract scalarization after scalarizing store.
Roman Lebedev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 17 11:07:26 PDT 2021
lebedev.ri added a comment.
In D100302#2949997 <https://reviews.llvm.org/D100302#2949997>, @fhahn wrote:
> In D100302#2941173 <https://reviews.llvm.org/D100302#2941173>, @lebedev.ri wrote:
>
>> I do not like the general direction VectorCombine seems to be going in.
>> Doing only a single pass and hoping that the second pass wouldn't do anything clearly leads to problems `if (!Load->user_empty()) {` is solving.
>> I would think we'd really want an instcombine-lite approach here, with a worklist..
>
> That's a fair point. But I think the same probably holds true fo somer other combines in VectorCombine. So should the whole pass just use a worklist?
That was my comment precisely.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100302/new/
https://reviews.llvm.org/D100302
More information about the llvm-commits
mailing list