[PATCH] D108180: [CSSPGO] Track and use context-sensitive post-optimization function size to drive global pre-inliner in llvm-profgen

[Wei Mi via Phabricator via llvm-commits]

wmi added inline comments.


================
Comment at: llvm/tools/llvm-profgen/ProfiledBinary.cpp:55
 
+void BinarySizeContextTracker::addInstructionForContext(
+    const FrameLocationStack &Context, uint32_t InstrSize) {
----------------
The function size computed for a certain context doesn't include the size of any function inlined into it. This matches well with top-down inline in sample loader, but may not match well with cgscc inliner. I forget how much inlining is done by the inliner in sample loader and how much is done by cgscc inliner for CSSPGO. Is it a problem right now?  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108180/new/

https://reviews.llvm.org/D108180