[PATCH] D108049: [InstCombine] Canonicalize saturate with shift and xor to min/max clamp
Simon Pilgrim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Aug 17 08:53:11 PDT 2021
RKSimon added a comment.
vector test cases?
================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp:862
+ // %cond.i = select i1 %cmp.not.i, i8 %conv1.i, i8 %xor.i
+ // ret i8 %cond.i
+ // }
----------------
If you're going to keep this in code, please can you simplify it (no entry: + better var names).
================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineSelect.cpp:874
+ return nullptr;
+ unsigned BW = cast<IntegerType>(Ty->getScalarType())->getBitWidth();
+ Value *Add;
----------------
How is BW different to Ty->getScalarSizeInBits() ?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108049/new/
https://reviews.llvm.org/D108049
More information about the llvm-commits
mailing list