[PATCH] D90234: [MCParser] Correctly handle Windows line-endings when consuming lexed line comments

Stephen Tozer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 17 08:22:40 PDT 2021


StephenTozer added a comment.

In D90234#2949482 <https://reviews.llvm.org/D90234#2949482>, @thakis wrote:

> Not quite sure why, but this breaks tests on my m1 bot: http://45.33.8.238/macm1/16248/step_11.txt
>
> Probably the `-mtriple=x86_64` means this needs a `REQUIRES:` line -- or the test should move into llvm/test/tools/llvm-mca/X86?
>
> Please take a look :)

Indeed, my mistake - I saw that error and have pushed a fix up for it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90234/new/

https://reviews.llvm.org/D90234



More information about the llvm-commits mailing list