[llvm] ad40cb8 - Fix: [MCParser] Correctly handle CRLF line ends when consuming line comments

via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 17 08:17:36 PDT 2021


Author: Tozer
Date: 2021-08-17T16:16:19+01:00
New Revision: ad40cb8821666a255ad9982b99ea0ce13a57dfaa

URL: https://github.com/llvm/llvm-project/commit/ad40cb8821666a255ad9982b99ea0ce13a57dfaa
DIFF: https://github.com/llvm/llvm-project/commit/ad40cb8821666a255ad9982b99ea0ce13a57dfaa.diff

LOG: Fix: [MCParser] Correctly handle CRLF line ends when consuming line comments

Fixes an issue with revision 5c6f748c.

Move the test added in the above commit into the X86 folder, ensuring
that it is only run on targets where its triple is valid.

Added: 
    llvm/test/tools/llvm-mca/X86/directives-handle-crlf.s

Modified: 
    llvm/.gitattributes

Removed: 
    llvm/test/tools/llvm-mca/directives-handle-crlf.s


################################################################################
diff  --git a/llvm/.gitattributes b/llvm/.gitattributes
index b41ae6aec97b3..8812053169ff6 100644
--- a/llvm/.gitattributes
+++ b/llvm/.gitattributes
@@ -17,4 +17,4 @@ test/YAMLParser/spec-09-02.test binary
 # binary and not autoconvert line endings (for example, when core.autocrlf is
 # on).
 test/MC/AsmParser/preserve-comments-crlf.s binary
-test/tools/llvm-mca/directives-handle-crlf.s binary
+test/tools/llvm-mca/X86/directives-handle-crlf.s binary

diff  --git a/llvm/test/tools/llvm-mca/directives-handle-crlf.s b/llvm/test/tools/llvm-mca/X86/directives-handle-crlf.s
similarity index 96%
rename from llvm/test/tools/llvm-mca/directives-handle-crlf.s
rename to llvm/test/tools/llvm-mca/X86/directives-handle-crlf.s
index aa5c0fc205f50..e62cdd269bc8f 100644
--- a/llvm/test/tools/llvm-mca/directives-handle-crlf.s
+++ b/llvm/test/tools/llvm-mca/X86/directives-handle-crlf.s
@@ -1,4 +1,4 @@
-# RUN: llvm-mca -mtriple=x86_64-unknown-unknown %s
-# LLVM-MCA-BEGIN foo
-addl	$42, %eax
-# LLVM-MCA-END
+# RUN: llvm-mca -mtriple=x86_64-unknown-unknown %s
+# LLVM-MCA-BEGIN foo
+addl	$42, %eax
+# LLVM-MCA-END


        


More information about the llvm-commits mailing list