[PATCH] D106783: [AIX][XCOFF][llvm-readobj] Replace unwrapOrError with reportUniqueWarning

Sean Fertile via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 17 08:01:07 PDT 2021


sfertile accepted this revision as: sfertile.
sfertile added a comment.

Hi Maryam.

Do you need someone to commit this for you? I don't think we were waiting for any further approvals (FWIW it LGTM also though). I made one small comment about removing some trailing whitespace, if you need someone to commit for you I can fix that and commit, just let me know.



================
Comment at: llvm/test/tools/llvm-readobj/XCOFF/relocations-invalid.test:8
+# INVALID-REL:      Relocations [
+# INVALID-REL-NEXT:   warning: '[[FILE]]': The end of the file was unexpectedly encountered 
+# INVALID-REL-NEXT: ]
----------------
Real minor nit: there is trailing whitespace at the end of this line.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106783/new/

https://reviews.llvm.org/D106783



More information about the llvm-commits mailing list