[PATCH] D105268: [X86] AVX512FP16 instructions enabling 5/6

[Pengfei Wang via Phabricator via llvm-commits]

pengfei added inline comments.


================
Comment at: clang/lib/Headers/avx512fp16intrin.h:2373
+      (__v32hf)(__m512h)(A), (__v32hf)(__m512h)(B), (__v32hf)(__m512h)(C),     \
+      (__mmask32)-1, (int)(R))
+
----------------
RKSimon wrote:
> Add outer brackets to all the defines to prevent precedence issues:
> ```
> #define _mm512_fmadd_round_ph(A, B, C, R)                                      \
>  ((__m512h) __builtin_ia32_vfmaddph512_mask(                                   \
>       (__v32hf)(__m512h)(A), (__v32hf)(__m512h)(B), (__v32hf)(__m512h)(C),     \
>       (__mmask32)-1, (int)(R)))
> ```
Thanks Simon.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105268/new/

https://reviews.llvm.org/D105268