[PATCH] D107651: [AArch64][SVE] Teach cost model that masked loads/stores are cheap

Peter Waller via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 17 05:35:35 PDT 2021


peterwaller-arm added inline comments.


================
Comment at: llvm/test/Analysis/CostModel/AArch64/masked_ldst_vls.ll:19
+
+define void @fixed-sve-vls() #0 {
+; CHECK-LABEL: 'fixed-sve-vls'
----------------
Minor nit: functions with dashes in the name are quite rare. I'm a little surprised it's allowed! Out of ~240k function definitions in the LLVM test suite, only 28 of them have dashes, and ~187k have underscores, so I'd go with the majority here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107651/new/

https://reviews.llvm.org/D107651



More information about the llvm-commits mailing list