[PATCH] D99354: [SimpleLoopUnswitch] Port partially invariant unswitch from LoopUnswitch to SimpleLoopUnswitch

Tue Aug 17 05:29:02 PDT 2021

jaykang10 added a comment.

In D99354#2949059 <https://reviews.llvm.org/D99354#2949059>, @xbolva00 wrote:

> In D99354#2912791 <https://reviews.llvm.org/D99354#2912791>, @jaykang10 wrote:
>
>> In D99354#2903817 <https://reviews.llvm.org/D99354#2903817>, @fhahn wrote:
>>
>>> @jaykang10 it looks like this patch regressed codegen in some cases: https://bugs.llvm.org/show_bug.cgi?id=51139. It would be great if you could take a look.
>>
>> Ah, let me have a look.
>
> Maybe revert while investigating?

As I mentioned on https://bugs.llvm.org/show_bug.cgi?id=51141, I am not sure the unswitch pass has to detect the cases which the loop load pre, sccp or other passes can optimize and the pass do not unswitch the loop...
I am creating a patch to fix https://bugs.llvm.org/show_bug.cgi?id=51141 first. The patch does not fix https://bugs.llvm.org/show_bug.cgi?id=51139. Once I create it, let me add you as reviewer.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99354/new/

https://reviews.llvm.org/D99354