[PATCH] D104975: Implement P1949

Aaron Ballman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 17 04:53:23 PDT 2021


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM aside from a commenting nit that I managed to miss last time (sorry about that). Btw, would you like to apply for commit privileges now that you've gotten a few patches under your belt (https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access)?



================
Comment at: clang/lib/Lex/Lexer.cpp:1661-1663
+    // We got a unicode codepoint that is neither a space nor a
+    // a valid identifier part
+    // Carry on as if the codepoint was valid for recovery purposes
----------------
Oops, I missed this one last time!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104975/new/

https://reviews.llvm.org/D104975



More information about the llvm-commits mailing list