[PATCH] D107968: [llvm-readobj] Refactor ELFDumper::printAttributes()

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In D107968#2948996 <https://reviews.llvm.org/D107968#2948996>, @jozefl wrote:

> Fixed in the attached.
>
> There's lots of warnings in ELFDumper.cpp that use the W.startLine() approach
> of printing warnings. As I understand from the LLVM Coding Standards, the
> community does not want patches that performs large-scale refactoring, such as
> changing the W.startLine to reportUniqueWarning, and changing the text to match
> current LLVM style. Given this, I assume a bug report that details this
> inconsistencies is not required, and that they will just get updated when the
> surrounding code next gets updated?

Yes, exactly.



================
Comment at: llvm/test/tools/llvm-readobj/ELF/RISCV/validate-attr-section.test:1
 ## We only implement attribute section printing for little-endian encoding.
 
----------------
Just realised that with the way you've refactored the code, we need an equivalent test for ARM too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107968/new/

https://reviews.llvm.org/D107968